-
-
Notifications
You must be signed in to change notification settings - Fork 136
Update plugin to support mypy 1.17.0 #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is strange. I haven't seen these issues on my side. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You updated
name = "wemake-python-styleguide"
version = "1.1.0"
Let's pin it to 1.0
for now :)
Oh? I didn't notice. I think I might have just ran |
yes, please :) |
Rebased against master and pinned version |
@sobolevn @Jazzinghen are there any plans to continue work on this PR? |
@svorcan-rho today [email protected] was released :) |
I was waiting for approval after my last commit. Was there something missing? |
the CI is still red, I would be happy to approve it after it is green :) |
check if we can unpin once this is merged: dry-python/returns#2149
A lot of errors seem to be not very related to what I did, however I'll try to fix them. They're quite a lot, I hope I won't break anything. |
Please, run |
I guess this PR became more of a "Update all the tests to run with the newer Mypy" than just that small change I did, haha |
Everything should be fixed now. |
Awesome! Almost all fixed. Thank you! 👍 |
This is strange. I don't get the same error on my PC. I'll try to reproduce it, otherwise I might need some more info than what the CI pipeline is printing. |
Oh, wait, the error is not generated by the command I was testing. I am dumb. |
Mypy 1.17 seems to have started analyzing a lot more attributes and some stuff does not exist in the objects checked.
This was a pretty long debugging session, however it seems like |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 80 81 +1
Lines 2485 2581 +96
Branches 437 44 -393
==========================================
+ Hits 2485 2581 +96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Amazing work! 🫶
Highly appreciate your time and effort!
Thank you for your patience! |
I have made things!
What was done
sampled_from
repr HypothesisWorks/hypothesis#4441)Checklist
CHANGELOG.md
Related issues
Closes #2148
I have not updated the readme as there is no strict reference to the supported mypy version, and it looks like the changelog contains release info, so I didn't touch that one either.
All the checks passed, even though I had to add an ignore flag in a function that was using some strange trait-based property access.
I used a solution very similar to the one used in typeddjango/django-stubs#2670 but I get the version info using
importlib
instead of the string in the module.