fix(api): flatten apps/api dist build output#352
Merged
collinsezedike merged 5 commits intoJul 13, 2026
Merged
Conversation
Remove the paths override for @meridian/shared and @meridian/stellar-sdk-helpers in apps/api/tsconfig.json — workspace symlink resolution already reaches both packages' own dist without it. Add an explicit rootDir: src, matching the drydocs#349 fix for stellar-sdk-helpers, so a stray inclusion can't silently change the output layout again. Also adds a CI check verifying apps/api/dist/index.js lands flat, per collinsezedike's suggestion on the issue. Fixes drydocs#350
|
@siddhanttiwari19 is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Matches the exclude pattern from drydocs#349 - without it, dist/__tests__/*.test.js would end up in the production build output alongside the flattened dist/index.js.
…/siddhanttiwari19/meridian into fix/350-api-tsconfig-dist-layout
collinsezedike
approved these changes
Jul 13, 2026
collinsezedike
left a comment
Collaborator
There was a problem hiding this comment.
Nice work on this one. Root cause correctly identified, and the fix mirrors #349 exactly.
Good to merge!
Collaborator
|
Thank you for your contribution, @siddhanttiwari19 If you're looking for what to pick up next, there are a few open issues in the repo right now. Maybe #371? Feel free to browse and grab whatever fits. |
Contributor
Author
|
Thanks, @collinsezedike! Appreciate the review and the pointer — I'll check out #371 and comment there if it's a good fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the paths override for @meridian/shared and @meridian/stellar-sdk-helpers in apps/api/tsconfig.json — workspace symlink resolution already reaches both packages' own dist without it. Add an explicit rootDir: src, matching the #349 fix for stellar-sdk-helpers, so a stray inclusion can't silently change the output layout again.
Also adds a CI check verifying apps/api/dist/index.js lands flat, per collinsezedike's suggestion on the issue.
Fixes #350
Summary
apps/api/tsconfig.jsonhad apathsoverride pointing@meridian/sharedand
@meridian/stellar-sdk-helpersat their rawsrcdirectories, thesame misconfiguration fixed in fix(web): validate faucet XDR and env-configure the faucet URL #349 for
stellar-sdk-helpers. Without anexplicit
rootDir, TypeScript inferred the common ancestor across allthree
srctrees as the build root, sopnpm --filter @meridian/api buildproduced
dist/apps/api/src/index.jsinstead of a flatdist/index.js—confirmed by reproducing the bug before applying this fix.
pathsoverride andbaseUrl, and set an explicit"rootDir": "src", mirroring the exact fix applied in fix(web): validate faucet XDR and env-configure the faucet URL #349. Workspacesymlink resolution already reaches both packages' own
distoutput viatheir
package.jsonmainfield, so no override is needed.lint-typecheckthat builds@meridian/apiandasserts
apps/api/dist/index.jsexists, so this can't silently regress athird time (per collinsezedike's suggestion on the issue).
Test plan
pnpm lint && pnpm typecheck && pnpm testpass locallymainfirst (rm -rf apps/api/dist && pnpm --filter @meridian/api build→ nesteddist/apps/api/src/index.js), then confirmed this branch produces a flatdist/index.jspnpm typecheck— 6/6 tasks passpnpm test— 7/7 packages, 163 tests passpnpm format:check— cleanCloses #350