chore: adopt dryvist org-default gitignore#9
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore file to exclude environment files, private keys, Ansible Vault files, generic secrets, cloud provider credentials, Doppler caches, Terraform states, and AI assistant local states. Feedback suggests refining several patterns: allowing encrypted Ansible Vault files (vault.yml/vault.yaml) to be committed, adding negations to prevent public keys (.pub) from being ignored, narrowing down the overly broad *credentials* pattern to avoid matching source code or documentation, and ensuring setup documentation like SECRETS_SETUP.md is not ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes
.gitignorecoverage as part of an org-wide hygiene initiative.Ensures common credential, secret-material, infrastructure-state, and tool-local
artifact paths are ignored consistently across dryvist repos, so files that
shouldn't be in version control aren't tracked by accident.
Adopts the relevant subset of the org-default baseline (
dryvist/.github→configs/gitignore). Append-only and de-duplicated — no existing entries aremodified or removed. Verified that no currently-tracked file becomes ignored.
Intentional carve-outs preserved (committed by convention):
.envrc,*.sops.*, and.terraform.lock.hcl.🤖 Generated with Claude Code