Add integration tests for Save-SqlDscSqlServerMediaFile command - #2268
Merged
Conversation
… command Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Integration test missing for Save-SqlDscSqlServerMediaFile
Add integration tests for Save-SqlDscSqlServerMediaFile command
Sep 18, 2025
Copilot stopped work on behalf of
johlju due to an error
September 18, 2025 10:39
johlju
requested changes
Sep 19, 2025
…message, add blank line ending, update README Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
johlju
marked this pull request as ready for review
September 19, 2025 19:34
johlju
requested changes
Sep 19, 2025
… same file twice instead of creating dummy ISO Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
johlju
requested changes
Sep 20, 2025
…oad to avoid ISO safety check Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
johlju
requested changes
Sep 20, 2025
…d - use Should -Throw instead of Should -Throw -ExpectedMessage Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
Copilot stopped work on behalf of
johlju due to an error
September 20, 2025 14:00
johlju
approved these changes
Sep 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
====================================
Coverage 94% 94%
====================================
Files 149 149
Lines 9163 9163
====================================
Hits 8687 8687
Misses 476 476
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save-SqlDscSqlServerMediaFilecommand functionalityShould -Throw -ExpectedMessage '*InvalidDestinationFolder*'toShould -ThrowLatest Refinement:
Simplified the error condition test in the integration tests by removing the specific error message check. Integration tests should focus on testing that the expected behavior occurs (error is thrown) rather than validating specific error messages, which is more appropriate for unit tests.
This follows integration testing best practices where we test the overall behavior and outcomes rather than implementation details like specific error messages.
Fixes #2237.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
This change is