Skip to content

Fix: ts-morph incorrectly transforms nodes which begin with whitespace #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

Fix: ts-morph incorrectly transforms nodes which begin with whitespace #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/ts-morph/src/compiler/ast/common/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,13 +1403,14 @@ export class Node<NodeType extends ts.Node = ts.Node> {
* This will forget the current node and return a new node that can be asserted or type guarded to the correct type.
* @param textOrWriterFunction - Text or writer function to replace with.
* @returns The new node.
* @remarks This will replace the text from the `Node#getStart(true)` position (start position with js docs) to `Node#getEnd()`.
* @remarks This will replace the text from the `Node#getStart(true)` (or `Node#getPos()` if `replaceFullText` is true) position (start position with js docs) to `Node#getEnd()`.
* Use `Node#getText(true)` to get all the text that will be replaced.
*/
replaceWithText(textOrWriterFunction: string | WriterFunction): Node;
/** @internal */
replaceWithText(textOrWriterFunction: string | WriterFunction, writer: CodeBlockWriter): Node;
replaceWithText(textOrWriterFunction: string | WriterFunction, writer?: CodeBlockWriter): Node {
replaceWithText(textOrWriterFunction: string | WriterFunction, writer: CodeBlockWriter, replaceFullText: boolean): Node;
replaceWithText(textOrWriterFunction: string | WriterFunction, writer?: CodeBlockWriter, replaceFullText?: boolean): Node {
const newText = getTextFromStringOrWriter(writer || this._getWriterWithQueuedIndentation(), textOrWriterFunction);
if (Node.isSourceFile(this)) {
this.replaceText([this.getPos(), this.getEnd()], newText);
Expand All @@ -1419,7 +1420,7 @@ export class Node<NodeType extends ts.Node = ts.Node> {
const parent = this.getParentSyntaxList() || this.getParentOrThrow();
const childIndex = this.getChildIndex();

const start = this.getStart(true);
const start = replaceFullText ? this.getPos() : this.getStart(true);
insertIntoParentTextRange({
parent,
insertPos: start,
Expand Down Expand Up @@ -1553,7 +1554,7 @@ export class Node<NodeType extends ts.Node = ts.Node> {
if (oldNode === newNode && (newNode as any).emitNode == null)
return;

const start = oldNode.getStart(compilerSourceFile, true);
const start = oldNode.kind === ts.SyntaxKind.JsxText ? oldNode.pos : oldNode.getStart(compilerSourceFile, true);
const end = oldNode.end;
let lastTransformation: Transformation | undefined;

Expand Down