Modifies BaseTransferService to have OAuth2 session as an attribute rather than extending it #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather than extending it
aborem
added a commit
that referenced
this pull request
Jul 22, 2025
This was referenced Jul 24, 2025
aborem
added a commit
that referenced
this pull request
Jul 25, 2025
Closes #30 and discussed in dtinit/pardner-site#10 (comment) * Creates stateless OAuth functions in `src/pardner/stateless/base.py`, which are adapted from the base service transfer class and its methods created in #24 #16 . Eventually other stateless functions will use these to make their requests (they're essentially wrappers for these core ones). * Extracts common logic and helpers in tests into conftest.py. Also needed to create new directories and modules in the test directory This doesn't change anything about the existing classes because using a class instance implies that you're okay with state, so making those optionally stateless is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5 , I realized that extending
OAuth2Sessionwas a bit overkill since we don't need the level of configurability it provides (e.g.,fetch_token's 16 arguments, of which we'll only ever use two).IIRC, it's usually better not to use inheritance in cases like these anyway (composition over inheritance?).