Feature: Support multiple function examples#410
Open
hatamiarash7 wants to merge 2 commits intoduckdb:mainfrom
Open
Feature: Support multiple function examples#410hatamiarash7 wants to merge 2 commits intoduckdb:mainfrom
hatamiarash7 wants to merge 2 commits intoduckdb:mainfrom
Conversation
Collaborator
|
Thanks, this makes sense, I would need to test this and come back. |
Contributor
Author
|
@carlopi, did you have a chance to test it? I saw that new changes had been applied, and there was a conflict. This was fixed, and I updated again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current configuration:
-markdownflag andvarchar[]typeIn this PR, the procedure of function extraction is changed to produce a multiline example of functions in the final cell. Also, show all examples as a
<code>block to look better.Before:
After:
Users can add multiple examples for their functions using a
\ndelimiter: