adding light capability #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudanov
requested changes
Aug 6, 2023
Owner
dudanov
left a comment
dudanov
left a comment
There was a problem hiding this comment.
Thanks! Which air conditioner model uses this feature?
Comment on lines
+126
to
+127
| /* DISPLAY LIGHT */ | ||
| Display getLight() const { return static_cast<Display>(this->m_getValue(14,7,4)); } |
Owner
There was a problem hiding this comment.
Suggested change
| /* DISPLAY LIGHT */ | |
| Display getLight() const { return static_cast<Display>(this->m_getValue(14,7,4)); } | |
| /* DISPLAY LIGHT */ | |
| Display getLight() const { return static_cast<Display>(this->m_getValue(14, 7, 4)); } |
Comment on lines
+67
to
+73
| /// Enum for display light setting | ||
| enum Display : uint8_t { | ||
| /// Display is off | ||
| DISPLAY_OFF=7, | ||
| /// Display is on | ||
| DISPLAY_ON=0 | ||
| }; |
Owner
There was a problem hiding this comment.
Suggested change
| /// Enum for display light setting | |
| enum Display : uint8_t { | |
| /// Display is off | |
| DISPLAY_OFF=7, | |
| /// Display is on | |
| DISPLAY_ON=0 | |
| }; | |
| /// Enum for display light setting | |
| enum Display : uint8_t { | |
| /// Display is off | |
| DISPLAY_OFF = 7, | |
| /// Display is on | |
| DISPLAY_ON = 0, | |
| }; |
Author
at least Midea air conditioners can switch off the display. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for querying display status