-
Notifications
You must be signed in to change notification settings - Fork 1.4k
bridges: fix the whole sector #8832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f73f55a to
a9593ae
Compare
… into bridges_fixxxxx
|
looks like it's still failing on dupes with the index in place? |
|
@jeff-dude it's ready now |
jeff-dude
approved these changes
Oct 21, 2025
|
@jeff-dude I included all changes made in #8833 into this PR, so only this PR needs to be merged now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes this trino error i've never encountered:
Error: No catalog handle for partitioning handle: SINGLEexample query with error (this is the target DuneSQL code of
bridges_evms.withdrawalswhich currently has theprod_excludetag due to this error): https://dune.com/queries/5901070@jonathandune found that it was a it was the query engine failing to plan the query and the materialising the UNION ALLs fixes the issue.
so bridges_evms_deposits.sql and bridges_evms_withdrawals.sql were each split into the _raw file and the current one, the _raw one joins all EVM chains and removes duplicates, the current one joins prices data
other fixes:
evmsandcrosschainlevel testsarbitrumin across macrosNote
Materializes EVMS union sources into raw views, adds deposit/withdrawal chain IDs and deduping, replaces Across hardcoded mappings with a shared index, and standardizes flows schemas incl. Across v3.
bridges_evms_depositsandbridges_evms_withdrawalsinto_rawunion views plus priced aggregates to fix planning issues; updated unique keys and incremental logic; addedduplicate_indexhandling.withdrawal_chain_id(deposits) anddeposit_chain_id(withdrawals/flows); propagated to crosschain and EVMS flows; updated tests and unique keys.withdrawal_*consistently and fixed column names in crosschain flows.bridges_across_chain_indexes; addedwithdrawal_chain_idto deposits and deduped withdrawals (ROW_NUMBER) for v2/v3; removed hardcoded chains.bridges_across_chain_indexeswith extra chains (e.g., Solana, HyperEVM, Plasma); updated CCTP indexes schema.Written by Cursor Bugbot for commit 83d0239. Configure here.