CUR2-757 Fix Somnex V2 Somnia #8882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
The model was incorrectly using the call_createpair table which stores tokens in the order they were passed to the function (tokenA, tokenB). However, the Uniswap V2 factory contract sorts addresses internally before creating pairs (smaller address = token0, larger address = token1). This caused buy/sell directions to be reversed when tokenA > tokenB. Additionally, removed the 1e10 division logic that was incorrectly applied to all swap amounts. Testing showed that the Swap events match ERC20 transfers exactly with no inflation bug, so the division was creating errors rather than fixing them. Changes: - Switch from somnexammfactory_call_createpair to somnexammfactory_evt_paircreated - Use event's token0/token1 (sorted) instead of call's tokenA/tokenB (unsorted) - Remove incorrect 1e10 division logic for amounts - Update seed file with correct test data (buy/sell were previously swapped) - Add missing transaction (evt_index 7) to seed file
krishgka
force-pushed
the
somnia_dex_fix
branch
from
c35f6ff to
f7472a3
Compare
github-actions
bot
added
ready-for-review
|
@krishgka without looking too closely, does this mean we can then also update this model to use the fork macro instead to keep clean? logic looks similar 🤔 |
jeff-dude
added
in review
Reduces code from 63 lines to 20 lines by using the standard macro that 187 other Uniswap V2 compatible DEXes use. This makes the code: - More maintainable - Consistent with other DEX models - Easier to review and understand - Automatically includes any future macro improvements The macro produces identical output to the manual code.
Yup you're right, changed it! |
jeff-dude
approved these changes
Oct 20, 2025
jeff-dude
added
ready-for-merging
and removed
in review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model was incorrectly using the call_createpair table which stores tokens in the order they were passed to the function (tokenA, tokenB). However, the Uniswap V2 factory contract sorts addresses internally before creating pairs (smaller address = token0, larger address = token1).
This caused buy/sell directions to be reversed when tokenA > tokenB.
Changes:
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: