Thorchain gold #8886
Merged
Thorchain gold #8886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| -- Audit fields (Trino conversions) | ||
| a._inserted_timestamp, | ||
| cast(from_hex(replace(cast(uuid() as varchar), '-', '')) as varchar) AS _audit_run_id, -- Trino equivalent of invocation_id |
There was a problem hiding this comment.
Bug: UUID Function Causes SQL Engine Compatibility Issues
The _audit_run_id column in several Thorchain gold models uses the uuid() function, which isn't supported across all SQL engines and can lead to runtime errors. This also creates inconsistent audit IDs within a single dbt run, impacting audit trail reliability. Some implementations further result in unreadable binary characters.
Additional Locations (7)
dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_pool_block_statistics.sql#L106-L107dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_pool_block_fees.sql#L46-L47dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_total_block_rewards.sql#L44-L45dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_pool_block_balances.sql#L51-L52dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_daily_tvl.sql#L43-L44dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_rewards_event_entries.sql#L51-L52dbt_subprojects/daily_spellbook/models/thorchain/gold/thorchain_defi_fact_block_rewards.sql#L44-L45
| @@ -0,0 +1,51 @@ | |||
| {{ config( | |||
| schema = 'thorchain_core', | |||
There was a problem hiding this comment.
Bug: Schema Misalignment for Thorchain Defi Fact Models
The thorchain_defi_fact_transfers.sql model is configured with schema = 'thorchain_core', conflicting with its thorchain_defi_fact_ naming pattern. This places the model in the wrong schema, deviating from established conventions for thorchain_defi_fact_* models.
This reverts commit fbb858c.
github-actions
bot
added
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information:
Note
Introduces a Thorchain gold layer: a new
thorchain_core_dim_blockplus extensive core/defi/gov fact tables wired to it, all incremental with deduplication and documented inschema.yml.thorchain_core_dim_block(time dims, partitioning, incremental merge) fromthorchain.block_log.dim_block)thorchain_core_fact_{transfer,set_mimir,network_version,instantiate,thorname_change,tss_keygen_success,tss_keygen_failure,wasm_contracts}_events.dim_blockor direct)fact_{active_vault,inactive_vault,affiliate_fee,asgard_fund_yggdrasil,gas,loan_open,loan_repayment,mint_burn,errata,failed_deposit,send,switch,reserve,pending_liquidity,pool,refund,outbound}_events.fact_{add,withdraw,liquidity_actions,swap_events,swaps,streaming_swap_details}_events.fact_{pool_block_balances,block_pool_depths,pool_block_statistics,pool_block_fees}.fact_{rewards_events,rewards_event_entries,total_block_rewards,total_value_locked,daily_tvl,daily_earnings}.fact_{transfers,upgrades,bond_events,bond_actions}.fact_scheduled_outbound_events.dim_block)thorchain_gov_fact_{new_node,set_version,set_node_mimir,set_node_keys,set_ip_address,validator_request_leave,slash,slash_points}_events.block_month,incremental_predicate), windowed deduplication, surrogate keys, audit fields; several models use Trino-compatible hashing.schema.ymlexpansion documenting all new models, columns, and tests (uniqueness/not-null).Written by Cursor Bugbot for commit 3deed56. Configure here.