-
-
Notifications
You must be signed in to change notification settings - Fork 864
Add non-root user by default #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ToshY!
Perhaps, instead of changing the Dockerfile, it would make sense to describe the changes to this PR in the documentation page?
I assume FrankenPHP relies on Caddy's decision to run as root by default. See the discussion on this topic in the Caddy repository: caddyserver/caddy-docker#104. |
Okay, would you recommend adding a (new) documentation page, or update an existing one? Edit I've moved it to a new documentation page. I understand the decision to not directly apply the changes to the Dockerfile and document it instead. Maybe something to take into consideration for next time (and start with non-root by default then). |
90fb72e
to
368a331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This template's documentation files use simple diffs, not patches.
How about adding a couple of examples of using the new arguments?
Fixes #679
Based on:
Using a non-root user is regarded as a best practice.
I am not sure what the "many issues" a non-root user could cause (which might need further explanation), but I was able to build the images (dev/prod targets) and run it on dev without any apparent issues. Requires further testing.