Repository navigation
docs: explain empty Flex marks for symfony/mercure-bundle - #970
Open
alexisLefebvre wants to merge 1 commit into
Open
alexisLefebvre wants to merge 1 commit into
alexisLefebvre wants to merge 1 commit into
Conversation
Flex skips a whole compose file once it contains the recipe's opening mark, so the empty mark in "services" keeps the recipe from adding a separate Mercure service, which Caddy already provides as a module. The comments on the "volumes" and override marks point back to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The role of the last
symfony/mercure-bundlemark is not obvious, especially whencompose.yamlgrows with new services and it ends with 2 stray lines, far away from the first mark.In fact, the question was already raised: #181 (comment)
This PR adds short comments to make it explicit, add details in the first occurrence and a short explanation in
compose.override.yaml.