Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox uses its own trust store, so the commands in
docs/tls.md(which update the system trust store) are not enough for it.Also, when the
caddy_datavolume is removed (e.g.docker compose down -v), Caddy generates a new local authority with the same name as the previous one. If Firefox still trusts the old root, it rejects the new chain withSEC_ERROR_BAD_SIGNATUREinstead of the usualSEC_ERROR_UNKNOWN_ISSUER(reported in #969 (comment)).Changes
docs/tls.md, explaining how to trust the authority (importroot.crt, or enablesecurity.enterprise_roots.enabled) and how to fixSEC_ERROR_BAD_SIGNATUREafter the authority is regenerated.Testing
Reproduced with Firefox (Playwright build) against FrankenPHP v1.13.0 / Caddy v2.11.7:
SEC_ERROR_UNKNOWN_ISSUERdocker compose down -v && docker compose up --wait: certificate error other thanSEC_ERROR_UNKNOWN_ISSUER, while the served chain still verifies withopenssl verifyagainst the newroot.crt