Behat2 renderer supports step config parameter "print_outp"#137
Open
mjainta wants to merge 2 commits into
Open
Behat2 renderer supports step config parameter "print_outp"#137mjainta wants to merge 2 commits into
mjainta wants to merge 2 commits into
Conversation
Author
|
Is this project abandoned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Right now, the Behat2 renderer does not support printing output from the steps. If a step prints somewith with "print_r()", "var_dump()", etc. then the HTML page won't display that.
I would like to propose supporting the parameter "print_outp" for the Behat2 renderer, and have provided this change for that.
With the change comes also an additional Behat test for the feature.
Is there any chance this gets into the master branch, and update the composer package with it?
Our project would be helped very much if it did, and I am happy to help to get it through.
I also have another branch where I did create a Docker container that is able to execute the tests locally. If you are interested, I could prepare another PR with that, potentially adding Github actions with it.
Please let me know what you think.
Best regards,
Martin