Load workout URL param at startup#295
Draft
jkburges wants to merge 1 commit intodvmarinoff:masterfrom
Draft
Conversation
Enable direct workout imports from external ZWO URLs so users can deep-link into Auuki without manual file uploads and immediately begin riding. No new gotchas; this relies on the remote endpoint allowing cross-origin fetches.
Owner
|
I do like the general idea, let me think about it.
|
Author
It is not, TBH I think I've got a fair amount more features and testing to do before I would make it public.
Definitely, any ZWO file accessible via HTTP GET, and with cross-origin configured, will work as this PR stands; it is not tied to my particular app any more than that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable direct workout imports from external ZWO URLs so users can deep-link into Auuki without manual file uploads and immediately begin riding.
e.g. given a URL pointing to a ZWO file, say http://my-app.com/threshold-intervals.zwo, then that workout can be loaded and ready to go in Auuki like so (in dev, i.e. localhost):
http://localhost:1234?workoutUrl=http%3A%2F%2Fmy-app.com%2Fthreshold-intervals.zwo
This saves manually downloading (from URL), and in Auuki loading, selecting and navigating to the workout.
This change relies on the remote endpoint hosting the ZWO allowing cross-origin fetches.