Prepare for Internal Presign & Sign Sessions #1623
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycscaly
commented
Dec 31, 2025
| output: Vec<u8>, | ||
| curve: DWalletCurve, | ||
| signature_algorithm: DWalletSignatureAlgorithm, | ||
| }, // todo: needs hash, hash_scheme: HashScheme }, |
ycscaly
commented
Dec 31, 2025
| (SessionType::InternalSign, SessionType::InternalSign) => self | ||
| .session_sequence_number | ||
| .cmp(&other.session_sequence_number), | ||
| // Internal sessions have lowest priority (come last) |
Contributor
Author
There was a problem hiding this comment.
shouldn't internal sign be highest priority? @omersadika
ycscaly
commented
Dec 31, 2025
| .decryption_key_shares(dwallet_network_encryption_key_id)?; | ||
|
|
||
| ProtocolCryptographicData::Sign { | ||
| // TODO: maybe better also create for internal differently |
ycscaly
commented
Dec 31, 2025
| } | ||
|
|
||
| impl DWalletMPCOutput { | ||
| // TODO: delete |
ycscaly
commented
Dec 31, 2025
| pub struct InternalSessionsStatusUpdate { | ||
| /// The authority that sent this status update. | ||
| pub authority: AuthorityName, | ||
| // TODO: delete |
Contributor
Author
There was a problem hiding this comment.
@omersadika you wanted me to delete it, but there's an issue, it will then mean the keys wouldn't be unique, and can't send multiple updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.