Skip to content

Conversation

wbernoudy
Copy link
Member

@wbernoudy wbernoudy commented Sep 24, 2025

Now Model.disjoint_lists() returns only the DisjointLists symbol. The DisjointList successors can be accessed by indexing/iterating the DisjointLists symbol.

This is backwards-compatibility breaking.

Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should implement DisjointLists.__getitem__().

For the return value, I agree this is much better but unfortunately changing the return value is a significant backwards compatibility break so we'd want to save that for a major release.

@wbernoudy wbernoudy force-pushed the feature/improve-disjoint-lists-interface branch from 804c468 to 2a0a517 Compare October 9, 2025 23:28
... and restore the old method with a deprecation warning.
@wbernoudy wbernoudy force-pushed the feature/improve-disjoint-lists-interface branch from 2a0a517 to 89d750d Compare October 9, 2025 23:33
@wbernoudy wbernoudy marked this pull request as ready for review October 9, 2025 23:36
@arcondello arcondello added the enhancement New feature or request label Oct 10, 2025
@arcondello arcondello merged commit 7534f09 into dwavesystems:main Oct 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants