QOL improvements for DisjointLists - #397
Merged
arcondello merged 3 commits intoOct 10, 2025
Merged
arcondello merged 3 commits into
arcondello merged 3 commits into
Conversation
arcondello
reviewed
Sep 24, 2025
arcondello
left a comment
arcondello
left a comment
Member
There was a problem hiding this comment.
I agree we should implement DisjointLists.__getitem__().
For the return value, I agree this is much better but unfortunately changing the return value is a significant backwards compatibility break so we'd want to save that for a major release.
wbernoudy
force-pushed
the
feature/improve-disjoint-lists-interface
branch
from
October 9, 2025 23:28
804c468 to
2a0a517
Compare
... and restore the old method with a deprecation warning.
wbernoudy
force-pushed
the
feature/improve-disjoint-lists-interface
branch
from
October 9, 2025 23:33
2a0a517 to
89d750d
Compare
wbernoudy
marked this pull request as ready for review
October 9, 2025 23:36
arcondello
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
Model.disjoint_lists()returns only theDisjointListssymbol. TheDisjointListsuccessors can be accessed by indexing/iterating theDisjointListssymbol.This is backwards-compatibility breaking.