Add transpose node/symbol #405
Open
+715
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastbodin
force-pushed
the
feauture/transpose_symbol
branch
from
dc1df20 to
f7cbaa2
Compare
fastbodin
commented
Oct 10, 2025
| // transpose indices | ||
| std::reverse(multi_index.begin(), multi_index.end()); | ||
| // convert multidimensional transpose indices to transpose flat index | ||
| transpose_update.index = ravel_multi_index(multi_index, node_shape); |
There was a problem hiding this comment.
Just realized there should be a way to condense the unravel_index, the reverse, and the ravel_multi_index into one and make this faster. Will inspect tomorrow.
There was a problem hiding this comment.
There was a way but it is a bit of a brain twister
arcondello
approved these changes
Oct 10, 2025
Finished C++ code and tests.
Added test for dynamic vector. Ensured that min(), max(), and integral() are stored in ValuesInfo and attached to node.
fastbodin
force-pushed
the
feauture/transpose_symbol
branch
2 times, most recently
from
011143a to
2e91c12
Compare
fastbodin
force-pushed
the
feauture/transpose_symbol
branch
from
2e91c12 to
65302e0
Compare
wbernoudy
reviewed
Oct 11, 2025
Comment on lines
+1210
to
+1219
| transpose_diff.reserve(array_ptr_->size_diff(state)); | ||
|
|
||
| for (const Update& update : pred_diff) { | ||
| // make a copy of the update | ||
| Update transpose_update = update; | ||
| // convert the index to the transpose index | ||
| transpose_update.index = convert_predecessor_index(update.index); | ||
| // save the converted update | ||
| transpose_diff.emplace_back(transpose_update); | ||
| } |
There was a problem hiding this comment.
I think you could also replace this with something like
transpose_diff.assign(pred_diff.begin(), pred_diff.end());
std::transform(
transpose_diff.cbegin(),
transpose_diff.cend(),
transpose_diff.begin(),
[this](const Update& u) { return Update(convert_predecessor_index(u.index), u.old, u.value; }
);or let convert_predecessor_index take an Update to make it even shorter.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think you should also add a test for a scalar (0-d) array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160