This repository was archived by the owner on Jan 26, 2023. It is now read-only.
Allow changing n_solutions. #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ratke <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 5 5
Lines 183 183
=======================================
Hits 176 176
Misses 7 7
Continue to review full report at Codecov.
|
arcondello
reviewed
Jun 7, 2021
| def sample(self, bqm, num_repeats=50, seed=None, algorithm=None, | ||
| verbosity=-1, timeout=2592000, solver_limit=None, solver=None, | ||
| target=None, find_max=False, **sample_kwargs): | ||
| target=None, find_max=False, n_solutions=20, **sample_kwargs): |
There was a problem hiding this comment.
Can we rename this num_reads? I know n_solutions is consistent with QBSolv locally, but we use num_reads in all of the other Ocean samplers.
|
Many thanks for your reply. I'll likely get to it this weekend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the title says it all. I found that useful for debugging in a project I use qbsolv for, and thought this could be useful to others too.