feat: [Page Builder] PageTypes: ElementalPage extension, LandingPage by jsirish · Pull Request #214 · dynamic/autopipe-testbed

jsirish · 2026-04-01T22:32:01Z

Implements #140

LandingPage PageType

Full-width landing page with no sidebar
Hero section custom fields (title/subtitle)
No child pages allowed (allowed_children = [])
Custom LandingPage.ss layout template
ElementalArea via extension support

ElementalPage Extension

Adds ElementalAreasExtension to page types via YAML
Configurable allowed blocks per page type
LandingPage restricted to TextBlock + ImageBlock only

Block Types

Block (base), TextBlock, ImageBlock
CMS fields tailored per block type

Configuration

pagebuilder.yml with block allowlists
ElementalArea element restrictions

Fixes #140

…sion - Block base class with title, description, sort order - TextBlock and ImageBlock implementations - LandingPage page type with elemental area support - ElementalPage extension for adding ElementalArea to Page types - YAML config for allowed blocks per page type - LandingPage.ss full-width template (no sidebar) - Hero section fields (title/subtitle) on LandingPage Implements #140

Copilot

Pull request overview

Adds a new “Page Builder” foundation intended to enable block-based editing (via Elemental) and introduces a new LandingPage page type with hero fields and block allowlisting.

Changes:

Introduces LandingPage page type with hero DB fields and intended block restrictions.
Adds an ElementalPage DataExtension intended to attach Elemental support to pages and expose an allowlist concept.
Adds initial block classes (Block, TextBlock, ImageBlock) plus YAML configuration for block restrictions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
app/src/PageBuilder/LandingPage.php	New landing page type with hero fields and intended block allowlist.
app/src/PageBuilder/ElementalPage.php	New extension intended to add Elemental support and block allowlisting.
app/src/PageBuilder/Block.php	Base block model class for page builder blocks.
app/src/PageBuilder/Blocks/TextBlock.php	New text block class and CMS field definition.
app/src/PageBuilder/Blocks/ImageBlock.php	New image block class and CMS field definition.
app/_config/pagebuilder.yml	Applies extension(s) and configures allowed blocks/elements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T22:38:34Z

app/src/PageBuilder/LandingPage.php

+class LandingPage extends SiteTree
+{
+    private static $table_name = 'PageBuilder_LandingPage';
+    private static $icon = 'silverstripe-elemental/images/element-icon.png';
+    private static $description = 'A landing page with elemental block-based editing. Full-width layout with no sidebar.';
+    private static $singular_name = 'Landing Page';
+    private static $plural_name = 'Landing Pages';
+
+    /**
+     * Landing pages should not have children.
+     */
+    private static $allowed_children = [];
+
+    /**
+     * Define allowed block types for landing pages.
+     */
+    private static $allowed_blocks = [
+        TextBlock::class,
+        ImageBlock::class,
+    ];


LandingPage extends SiteTree, but page-level extensions are being applied to Page in YAML. As written, LandingPage won’t inherit the Page extension(s) (including your Elemental integration), and the allowed block class references are also inconsistent (TextBlock/ImageBlock aren’t imported and don’t match the declared block namespaces). Consider extending Page (or applying the same extensions directly to LandingPage) and using fully-qualified block class names that match the actual namespaces.

Copilot · 2026-04-01T22:38:34Z

app/src/PageBuilder/LandingPage.php

+    public function getCMSFields()
+    {
+        $fields = parent::getCMSFields();
+        $fields->addFieldToTab('Root.Hero', new Tab('Hero'));
+        return $fields;
+    }


The Hero tab is added but no fields are added for HeroTitle/HeroSubtitle, so these DB fields won’t be editable in the CMS. Add appropriate form fields (e.g., TextField/TextareaField) to the tab, or remove the unused DB fields/tab.

Copilot · 2026-04-01T22:38:35Z

app/src/PageBuilder/LandingPage.php

+
+    public function canCreate($member = null, $context = [])
+    {
+        return parent::canCreate($member, $context);
+    }
+
+    public function canEdit($member = null)
+    {
+        return parent::canEdit($member);
+    }
+
+    public function canDelete($member = null)
+    {
+        return parent::canDelete($member);
+    }
+
+    public function canView($member = null)
+    {
+        return parent::canView($member);
+    }


These permission methods simply delegate to the parent implementation without adding any logic, which increases noise/maintenance cost. Remove these overrides unless you’re planning to change the permission behavior.

Suggested change

public function canCreate($member = null, $context = [])

{

return parent::canCreate($member, $context);

}

public function canEdit($member = null)

{

return parent::canEdit($member);

}

public function canDelete($member = null)

{

return parent::canDelete($member);

}

public function canView($member = null)

{

return parent::canView($member);

}

Copilot · 2026-04-01T22:38:35Z

app/src/PageBuilder/ElementalPage.php

+class ElementalPage extends DataExtension
+{
+    private static $extensions = [
+        ElementalAreasExtension::class,
+    ];
+


Defining private static $extensions inside a DataExtension doesn’t apply those extensions to the owner; it applies extensions to the extension class itself. This likely means ElementalAreasExtension is never actually added to Page/LandingPage. Apply ElementalAreasExtension via YAML to the page type(s), or attach it programmatically to the owner in a supported way.

Copilot · 2026-04-01T22:38:35Z

app/src/PageBuilder/ElementalPage.php

+    public function updateCMSFields(FieldList $fields)
+    {
+        // ElementalAreaExtension handles the ElementalArea tab automatically
+        return $fields;
+    }
+
+    /**
+     * Get list of allowed block types for this page.
+     */
+    public function getAllowedBlocks()
+    {
+        $allowed = $this->owner->config()->get('allowed_blocks');
+        if (empty($allowed) && !$this->owner->config()->get('allow_all_blocks')) {
+            return [];
+        }
+        return $allowed ?: 'all';
+    }


getAllowedBlocks() returns either an array or the string 'all', which is a mixed return type and will be awkward/unsafe for callers. Also, nothing in this extension currently uses allowed_blocks to actually enforce Elemental allowed elements, so the allowlist configured in YAML won’t have any effect. Consider returning a consistent type (e.g., array) and wiring it into Elemental’s allowlist mechanism.

Copilot · 2026-04-01T22:38:37Z

app/_config/pagebuilder.yml

+App\PageBuilder\LandingPage:
+  allowed_blocks:
+    - App\PageBuilder\Blocks\TextBlock
+    - App\PageBuilder\Blocks\CarouselBlock


This allowlist references App\\PageBuilder\\Blocks\\CarouselBlock, but there is no CarouselBlock class in the PR. This will cause configuration errors and contradicts the PR description (LandingPage restricted to TextBlock + ImageBlock). Update the list to only include existing block classes.

Suggested change

- App\PageBuilder\Blocks\CarouselBlock

- App\PageBuilder\Blocks\ImageBlock

Copilot · 2026-04-01T22:38:37Z

app/_config/pagebuilder.yml

+    - App\PageBuilder\Blocks\TextBlock
+    - App\PageBuilder\Blocks\CarouselBlock
+
+# Default elemental area configuration
+DNADesign\Elemental\Areas\ElementalArea:
+  allowed_elements:
+    - App\PageBuilder\Blocks\TextBlock


allowed_elements references App\\PageBuilder\\Blocks\\TextBlock, but TextBlock is currently declared under a different namespace in this PR. Align the class namespace/reference, otherwise Elemental’s allowed_elements restriction will not work (and may error on class lookup).

Suggested change

- App\PageBuilder\Blocks\TextBlock

- App\PageBuilder\Blocks\CarouselBlock

# Default elemental area configuration

DNADesign\Elemental\Areas\ElementalArea:

allowed_elements:

- App\PageBuilder\Blocks\TextBlock

- App\Blocks\TextBlock

- App\PageBuilder\Blocks\CarouselBlock

# Default elemental area configuration

DNADesign\Elemental\Areas\ElementalArea:

allowed_elements:

- App\Blocks\TextBlock

Copilot · 2026-04-01T22:38:37Z

app/src/PageBuilder/LandingPage.php

+/**
+ * LandingPage - a full-width page type for marketing/landing pages with block-based editing.
+ * 
+ * Applies Elemental support for flexible content assembly.
+ * Uses full-width layout with no sidebar.
+ */


PR description mentions a custom LandingPage template/layout, but there is no LandingPage .ss template added under app/templates in this PR. Without a template (and given this class is namespaced), SilverStripe template resolution is likely to fall back to a generic template or fail to find the intended layout.

Copilot · 2026-04-01T22:38:37Z

app/src/PageBuilder/ElementalPage.php

+use SilverStripe\CMS\Model\SiteTree;
+use DNADesign\Elemental\Extensions\ElementalAreasExtension;
+use DNADesign\Elemental\Extensions\ElementalAreasExtensionTrait;


These imports are currently unused (SiteTree, ElementalAreasExtensionTrait) which adds noise and can confuse future readers about intended behavior. Remove unused imports or implement the intended use.

Suggested change

use SilverStripe\CMS\Model\SiteTree;

use DNADesign\Elemental\Extensions\ElementalAreasExtension;

use DNADesign\Elemental\Extensions\ElementalAreasExtensionTrait;

use DNADesign\Elemental\Extensions\ElementalAreasExtension;

Copilot · 2026-04-01T22:38:37Z

app/src/PageBuilder/Blocks/ImageBlock.php

+use SilverStripe\Forms\FieldList;
+use SilverStripe\Forms\TextField;
+use SilverStripe\Forms\FileField;
+use SilverStripe\Assets\Image;
+
+/**
+ * ImageBlock - displays an image with optional caption and alt text.
+ * @property string $AltText
+ * @property string $Caption
+ * @property int $ImageID


Docblock references $ImageID, but the relation is declared as ImageFile (and there is no ImageID field). Update the docblock (and consider removing unused imports like FileField/FieldList) to match the actual schema.

Suggested change

use SilverStripe\Forms\FieldList;

use SilverStripe\Forms\TextField;

use SilverStripe\Forms\FileField;

use SilverStripe\Assets\Image;

/**

* ImageBlock - displays an image with optional caption and alt text.

* @property string $AltText

* @property string $Caption

* @property int $ImageID

use SilverStripe\Forms\TextField;

use SilverStripe\Assets\Image;

/**

* ImageBlock - displays an image with optional caption and alt text.

* @property string $AltText

* @property string $Caption

* @property int $ImageFileID

Copilot AI review requested due to automatic review settings April 1, 2026 22:32

Copilot started reviewing on behalf of jsirish April 1, 2026 22:32 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [Page Builder] PageTypes: ElementalPage extension, LandingPage#214

feat: [Page Builder] PageTypes: ElementalPage extension, LandingPage#214
jsirish wants to merge 1 commit intomainfrom
autopipe/issue-140

jsirish commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	- App\PageBuilder\Blocks\CarouselBlock
	- App\PageBuilder\Blocks\ImageBlock

Conversation

jsirish commented Apr 1, 2026

LandingPage PageType

ElementalPage Extension

Block Types

Configuration

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants