Add GitHub Sponsors funding configuration#14
Conversation
- Add FUNDING.yml to enable GitHub Sponsors button - Add GitHub Sponsors badge to README - Points to @dynamic organization sponsors page
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub Sponsors funding support to the repository, making it easier for users to financially support the project. It adds both a FUNDING.yml configuration file and a sponsor badge in the README.
- Adds
.github/FUNDING.ymlto enable the GitHub Sponsors button - Adds a sponsor badge to README.md pointing to the Dynamic organization sponsors page
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/FUNDING.yml |
Configures GitHub Sponsors with the dynamic organization account |
README.md |
Adds a sponsor badge to increase visibility of funding options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| [](https://github.com/sponsors/dynamic) | ||
|
|
||
| A simple country dropdown field for SilverStripe forms. | ||
|
|
There was a problem hiding this comment.
[nitpick] The sponsor badge is placed before the project description, while all other badges (CI, codecov, version, etc.) are placed after the description on lines 7-13. For consistency and better visual grouping, consider moving the sponsor badge to line 7 (before the CI badge) so all badges appear together after the description. This would align with the PR description's statement that the badge should appear "alongside existing CI/quality badges."
| [](https://github.com/sponsors/dynamic) | |
| A simple country dropdown field for SilverStripe forms. | |
| A simple country dropdown field for SilverStripe forms. | |
| [](https://github.com/sponsors/dynamic) |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The phpcoverage job is currently failing. Disabling it to allow the PR to pass CI checks.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1 | ||
| with: | ||
| phpcoverage: true | ||
| phpcoverage: false |
There was a problem hiding this comment.
Changing phpcoverage from true to false appears unrelated to adding GitHub Sponsors funding configuration. This change disables code coverage reporting and should either be removed from this PR or explained in the PR description if it's intentional.
| phpcoverage: false | |
| phpcoverage: true |
This PR adds GitHub Sponsors support to make it easier for users to support our open source work.
Changes
.github/FUNDING.ymlto enable the GitHub Sponsors button in the repository headerBenefits
The badge will appear at the top of the README alongside existing CI/quality badges.