Merge SS5 branch (2) into SS6 branch (3) #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR merges SS5 refactoring changes into the SS6 branch, specifically removing the getType() method override in favor of using the $singular_name configuration property for better extensibility. The changes also remove outdated composer branch-alias configuration and CI coverage settings.
Key Changes:
- Removed
getType()method override fromElementCardto leverage$singular_nameconfiguration property - Removed deprecated
branch-aliasconfiguration from composer.json - Removed
phpcoverageflag from CI workflow configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Element/ElementCard.php | Removes getType() method override to allow extensibility via the existing $singular_name = 'Card' configuration |
| composer.json | Removes deprecated branch-alias configuration that pointed to 2.x-dev |
| .github/workflows/ci.yml | Removes phpcoverage: true configuration from CI workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge the SS5 branch into the SS6 branch to bring forward the
getType()refactor changes.Changes from SS5 branch
getType()method override to allow extensibility via$singular_nameRelated