Skip to content

Conversation

@jsirish
Copy link
Member

@jsirish jsirish commented Nov 19, 2025

Updates the README to reflect SilverStripe 6 compatibility and improvements.

Changes

  • Badges: Removed codecov badge, added GitHub Sponsors badge, reorganized layout
  • Requirements: Updated to PHP ^8.3, SilverStripe ^6, Elemental ^6, Carousel ^3
  • Features: Added section highlighting 5 key capabilities:
    • Carousel Block for image carousels
    • Slide Management with CMS controls
    • Flexible Configuration (transitions, autoplay, intervals)
    • Bootstrap 5 Support with optimized templates
    • Content Integration for rich-text alongside slides
  • Upgrade Notes: Added migration guidance from version 2 to 3

Complements the v3.0.0 code release.

- Update badges (remove codecov, add GitHub Sponsors)
- Update requirements to SS6 versions (PHP ^8.3, SS ^6, Elemental ^6, Carousel ^3)
- Add Features section highlighting key capabilities
- Add upgrade notes for version 2 to 3 migration
- Reorganize badges for better readability
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README documentation to reflect compatibility with SilverStripe 6 and the v3.0.0 release of the module.

  • Reorganized badges, removing codecov and adding GitHub Sponsors support
  • Updated minimum version requirements to PHP 8.3+, SilverStripe 6, Elemental 6, and Carousel 3
  • Added a Features section documenting 5 key capabilities of the module
  • Added upgrade guidance for users migrating from version 2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +14
* dnadesign/silverstripe-elemental ^6
* dynamic/silverstripe-carousel ^3
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent package name formatting. The requirements section uses inconsistent naming conventions:

  • Line 13: dnadesign/silverstripe-elemental ^6 (missing colon after package name)
  • Line 14: dynamic/silverstripe-carousel ^3 (missing colon after package name)

These should follow the same format as the Installation section (line 18) or use bullet list format consistently. Suggest:

* dnadesign/silverstripe-elemental: ^6
* dynamic/silverstripe-carousel: ^3

or

* dnadesign/silverstripe-elemental ^6
* dynamic/silverstripe-carousel ^3

but be consistent with lines 11-12.

Suggested change
* dnadesign/silverstripe-elemental ^6
* dynamic/silverstripe-carousel ^3
* dnadesign/silverstripe-elemental: ^6
* dynamic/silverstripe-carousel: ^3

Copilot uses AI. Check for mistakes.
* dnadesign/silverstripe-elemental: ^5.0
* dynamic/silverstripe-carousel: ^2.0
* PHP ^8.3
* SilverStripe ^6
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent product name formatting. Line 11 uses "SilverStripe" while line 12 uses "dnadesign/silverstripe-elemental" (lowercase). For consistency with the product name conventions, consider using either:

  • "SilverStripe CMS ^6" (matching the upgrade notes on line 52)
  • Or maintain the bullet list format consistently across all requirements

This would align with how other requirements list versions (e.g., lines 13-14).

Suggested change
* SilverStripe ^6
* silverstripe/cms ^6

Copilot uses AI. Check for mistakes.

## Features

- **Carousel Block**: Elemental block for image carousels
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing article. The phrase "Elemental block for image carousels" should be "An Elemental block for image carousels" for proper grammar.

Suggested change
- **Carousel Block**: Elemental block for image carousels
- **Carousel Block**: An Elemental block for image carousels

Copilot uses AI. Check for mistakes.
@jsirish jsirish merged commit dc32884 into master Nov 19, 2025
20 of 22 checks passed
@jsirish jsirish deleted the 3.0/readme-update branch November 19, 2025 02:27
jsirish added a commit that referenced this pull request Nov 19, 2025
- Add colons after package names in requirements for consistency
- Add article 'An' to Carousel Block feature for proper grammar

Addresses Copilot review feedback on PR #11
jsirish added a commit that referenced this pull request Nov 19, 2025
* docs: Fix README formatting consistency

- Add colons after package names in requirements for consistency
- Add article 'An' to Carousel Block feature for proper grammar

Addresses Copilot review feedback on PR #11

* ci: Remove phpcoverage configuration

Simplifies CI workflow by removing phpcoverage option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant