Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the module to be compatible with SilverStripe 6, preparing it for a v4.0.0 release. The upgrade includes updated PHP requirements, dependency version bumps, and addition of GitHub sponsor funding links.
- Updated PHP requirement to ^8.1 to meet SilverStripe 6 minimum requirements
- Upgraded core dependencies: silverstripe-elemental from ^4 to ^6, gridfieldextensions from ^3 to ^5, and recipe-testing from ^2 to ^6
- Added GitHub Sponsors funding configuration and badge
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updated PHP requirement to ^8.1, upgraded dependencies to SilverStripe 6 compatible versions, and added funding metadata |
| README.md | Replaced codecov badge with GitHub Sponsors badge |
| .github/workflows/ci.yml | Disabled PHP coverage reporting |
| .github/FUNDING.yml | Added GitHub Sponsors funding configuration for the dynamic organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update PHP requirement to ^8.3 - Update dnadesign/silverstripe-elemental: ^4 -> ^6 - Update silverstripe/framework: ^4 -> ^6 - Update symbiote/silverstripe-gridfieldextensions: ^3 -> ^5 - Update silverstripe/recipe-testing: ^2 -> ^4 - Remove branch-alias configuration - All tests passing (13/13, 27 assertions)
jsirish
force-pushed
the
4.0/ss6-upgrade
branch
from
56be5b9 to
5489299
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "dnadesign/silverstripe-elemental": "^5.0", | ||
| "silverstripe/framework": "^5", | ||
| "symbiote/silverstripe-gridfieldextensions": "^4.0" | ||
| "php": "^8.3", |
There was a problem hiding this comment.
[nitpick] The PHP version constraint ^8.3 may be overly restrictive. SilverStripe 6 typically supports PHP 8.1 and above. Unless there's a specific reason to require PHP 8.3+, consider using ^8.1 to allow for broader compatibility with PHP 8.1 and 8.2 installations.
| "php": "^8.3", | |
| "php": "^8.1", |
1 participant
Upgrades the module to SilverStripe 6 compatibility.
Changes
dnadesign/silverstripe-elemental: ^4 → ^6silverstripe/framework: ^4 → ^6symbiote/silverstripe-gridfieldextensions: ^3 → ^5silverstripe/recipe-testing: ^2 → ^4Testing
This prepares the module for the 4.0.0 release.