Skip to content

Adding german translations#13

Merged
jsirish merged 18 commits intodynamic:mainfrom
moritz-sauer-13:main
Nov 20, 2025
Merged

Adding german translations#13
jsirish merged 18 commits intodynamic:mainfrom
moritz-sauer-13:main

Conversation

@moritz-sauer-13
Copy link
Contributor

Added german translations and fixed some typos.

@muskie9
Copy link
Member

muskie9 commented Oct 31, 2025

Hi @moritz-sauer-13, thanks for contributing and sorry we missed the initial PR. If you would be willing to hold on the SS6 work and ensure the previous work is rebased we can review and get the previous work merged. That will allow us to create a new release with the current version and then have the SS6 work be a new major version.

…ch-alias

- Restore correct package name: dynamic/silverstripe-user-invitation
- Keep author credit for Moritz Sauer (translator)
- Remove unnecessary dev dependencies (rector, phpstan, silverstripe-rector)
- Add cambis/silverstan for PHPStan support
- Restore branch-alias for proper versioning
- Remove project-files-installed (not needed)
- Preserve German translations (lang/de.yml)
- Add Moritz Sauer to authors for translation contribution
- Use main's version of all code files (already SS6-compatible)
Copy link
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @moritz-sauer-13! 👋

Thank you so much for contributing German translations to this module - they're very valuable and we'd love to include them!

Your PR was created against the repository's earlier code, and since then we've merged several updates including SilverStripe 6 compatibility. To help integrate your excellent translations while keeping everything up to date, I've created a cleanup branch cleanup/pr-13-translations that:

Preserves your contributions:

  • ✅ All German translations (lang/de.yml) - 55 translation keys
  • ✅ Your author credit in composer.json

Updates the technical requirements:

  • Fixed package name (was "moritz-sauer-13/silverstripe-user-invitation", restored to "dynamic/silverstripe-user-invitation")
  • Cleaned up dependencies (removed rector/phpstan/silverstripe-rector, added cambis/silverstan)
  • Restored branch-alias configuration
  • Merged all SS6 updates from main branch

Validation (all passing):

Next steps - your choice:

Option A: You can merge cleanup/pr-13-translations into your pr-13-translations branch, then update this PR

Option B: If you prefer, I can push the cleanup directly to your fork (would need your permission)

Let me know which approach works best for you, or if you have any questions about the changes!

Thanks again for the contribution! 🙏

@moritz-sauer-13
Copy link
Contributor Author

Hi @jsirish,

Unfortunately, I don't have the time to make the necessary adjustments right now, so I've just given you access to the fork. Is that enough for you? Or do you need further permissions, or perhaps a colleague of yours?
Unfortunately, I didn't know that changes to the fork would still be included in the pull request if the changes were made after the pull request... I find that a bit strange. Originally, it was really just the translations, but in the meantime, it's also the SS6 upgrade.

@jsirish
Copy link
Member

jsirish commented Nov 20, 2025

hey @moritz-sauer-13. Thanks for the access, i'll try to circle back to this by the end of the week.
Basically this PR needed a rebase, so that's the bulk of what I did off your branch. I"ll likely push that commit to your fork branch to update this pr, then we can merge it into the ss6 branch.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds German translations for the UserInvitations module and fixes spelling inconsistencies in translation keys across template files. The changes correct typos where UserInvation was used instead of UserInvitation, and where template translations incorrectly referenced UserController namespace instead of UserInvitation.

Key Changes

  • Fixed translation key typos in 4 template files (UserInvationUserInvitation, UserControllerUserInvitation)
  • Added comprehensive German translation file with translations for all user invitation features
  • Added contributor information to composer.json

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/Dynamic/SilverStripe/UserInvitations/Control/Layout/UserController_success.ss Fixed translation key from UserController.ACCEPTED_BODY to UserInvitation.ACCEPTED_BODY_SUCCESS
templates/Dynamic/SilverStripe/UserInvitations/Control/Layout/UserController_notfound.ss Fixed translation key from UserController.NOTFOUND_BODY to UserInvitation.NOTFOUND_BODY
templates/Dynamic/SilverStripe/UserInvitations/Control/Layout/UserController_expired.ss Fixed translation key from UserController.EXPIRED_BODY to UserInvitation.EXPIRED_BODY
templates/Dynamic/SilverStripe/UserInvitations/Control/Layout/UserController.ss Fixed translation keys from UserInvation to UserInvitation (correcting spelling typo)
lang/de.yml Added German translations for all UserInvitation components, but includes duplicate section with typo
composer.json Added Moritz Sauer as a contributor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +6 to +18
UserInvation:
EMAIL_SUBJECT: "Einladung von {name}"
INVITEFORM_HEADING: "Benutzereinladung"
INVITEFORM_BODY: "Geben Sie unten die Daten der Person ein, die Sie einladen möchten."
ACCEPTED_SIGN_UP: "Registrieren"
ACCEPTED_BODY: "Füllen Sie das folgende Formular aus, um Ihre Anmeldung für {name} zu bestätigen"
EXPIRED_HEADING: "Einladung ist abgelaufen"
EXPIRED_BODY: "Ups, Sie haben zu lange gebraucht, um diese Einladung anzunehmen."
NOTFOUND_HEADING: "Einladung nicht gefunden"
NOTFOUND_BODY: "Ups, die Einladungs-ID wurde nicht gefunden."
ACCEPTED_HEADING: "Herzlichen Glückwunsch!"
ACCEPTED_LOGIN_LINK_TEXT: "Klicken Sie hier, um sich einzuloggen."
ACCEPTED_BODY_SUCCESS: "Sie sind jetzt ein registriertes Mitglied."
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UserInvation section (lines 6-18) is a duplicate with a typo and should be removed. The correct spelling UserInvitation is already defined below (lines 19-36) with the same translations. This duplicate section serves no purpose and should be deleted.

Note: While the typo UserInvation exists in the source code at src/Model/UserInvitation.php:130, it should also be fixed there rather than maintaining translations for both the typo and the correct spelling.

Suggested change
UserInvation:
EMAIL_SUBJECT: "Einladung von {name}"
INVITEFORM_HEADING: "Benutzereinladung"
INVITEFORM_BODY: "Geben Sie unten die Daten der Person ein, die Sie einladen möchten."
ACCEPTED_SIGN_UP: "Registrieren"
ACCEPTED_BODY: "Füllen Sie das folgende Formular aus, um Ihre Anmeldung für {name} zu bestätigen"
EXPIRED_HEADING: "Einladung ist abgelaufen"
EXPIRED_BODY: "Ups, Sie haben zu lange gebraucht, um diese Einladung anzunehmen."
NOTFOUND_HEADING: "Einladung nicht gefunden"
NOTFOUND_BODY: "Ups, die Einladungs-ID wurde nicht gefunden."
ACCEPTED_HEADING: "Herzlichen Glückwunsch!"
ACCEPTED_LOGIN_LINK_TEXT: "Klicken Sie hier, um sich einzuloggen."
ACCEPTED_BODY_SUCCESS: "Sie sind jetzt ein registriertes Mitglied."

Copilot uses AI. Check for mistakes.
@jsirish jsirish merged commit 6c00de3 into dynamic:main Nov 20, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants