Bugfix/ignore outside densities

[JenHardt]

Making of ignoreOutsideDensities and useGivenEqDensityCube consistent between stf generation and dose engines, a problem for the dose engines arose because the analytcial calculation was performed on the RSP cube, where ignoreOutsideDensities was applied, but the MC would often dirrectly use the HU cube to do material conversion, where this was not applied

[read-the-docs-community]

Documentation build overview

📚 matRad | 🛠️ Build #32632322 | 📁 Comparing e73b6e4 against latest (c014dc8)

  🔍 Preview build  

38 files changed · + 1 added · ± 37 modified

+ Added

• datastructures/userfolder.html

± Modified

• genindex.html
• index.html
• api/4D.html
• api/IO.html
• api/basedata.html
• api/bioModels.html
• api/brachytherapy.html
• api/dicom.html
• api/doseCalc.html
• api/geometry.html
• and 27 more...

[codecov]

Codecov Report

❌ Patch coverage is 33.91304% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.79%. Comparing base (adf48b0) to head (e73b6e4).

Files with missing lines	Patch %	Lines
matRad/MatRad_Config.m	10.14%	62 Missing ⚠️
...nes/@matRad_DoseEngineBase/matRad_DoseEngineBase.m	69.56%	7 Missing ⚠️
matRad/util/matRad_interp3.m	42.85%	4 Missing ⚠️
matRad/steering/matRad_StfGeneratorBase.m	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #900      +/-   ##
==========================================
- Coverage   54.80%   54.79%   -0.02%     
==========================================
  Files         320      320              
  Lines       20548    20567      +19     
==========================================
+ Hits        11261    11269       +8     
- Misses       9287     9298      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Test Results

    3 files  ±0      3 suites  ±0   34m 31s ⏱️ + 2m 39s
  358 tests +1    354 ✅  - 3  0 💤 ±0  4 ❌ +4 
1 170 runs  +3  1 161 ✅  - 1  5 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit e73b6e4. ± Comparison against base commit adf48b0.

♻️ This comment has been updated with latest results.

[wahln]

This is very nice for computation consistency, thanks.

The code itself looks very nice, but could you add some minimal tests to check the correct behavior? Probably its difficult to catch the corresponding warnings, but you could probably check the resulting dose / generated stf's if you see the expected discrepancies.

[wahln]

Additionally, some documentation for this consistency between stf and dosecalc might be helpful

[JenHardt]

This is very nice for computation consistency, thanks.

The code itself looks very nice, but could you add some minimal tests to check the correct behavior? Probably its difficult to catch the corresponding warnings, but you could probably check the resulting dose / generated stf's if you see the expected discrepancies.

i think to check the expected result i would have to create a new test ct, because our current dummy test ct only has air outside of the patient anyway. I could create a new one with a dummy couch to test the behavior

[wahln]

Final requests from my side:

• can you fix the merge conflicts by a branch update from develop?
• can you add the change to the new changelog?

[JenHardt]

Final requests from my side:

• can you fix the merge conflicts by a branch update from develop?
• can you add the change to the new changelog?

done