Use per-fraction reference doses in quality indicators#904
Open
acsevillam wants to merge 1 commit into
Open
Conversation
Contributor
|
This is nice and makes it more consistent. The per fraction thing is anyway something that is very strongly debated among us, so the conversion function for the modes is also good. I just realized you opened the PR onto dev_varRBErobOpt - could you rebase/reopen onto dev? dev_varRBErobOpt was merged into dev quite some time ago. If yes, please close this PR when the new one is reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Quality indicators mixed per-fraction dose cubes with total prescription/objective doses in some analysis paths.
Approach
This PR keeps canonical quality indicators in per-fraction dose units and adds explicit conversion helpers for display/evaluation in total dose when requested.
Open Questions and/or Concerns
References
None.