-
Notifications
You must be signed in to change notification settings - Fork 667
feat: add template init for new SDK #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0d054f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
870e064
to
03faeb9
Compare
17317b7
to
cb31989
Compare
03faeb9
to
e6c7cb1
Compare
cb31989
to
c87de76
Compare
e6c7cb1
to
2981fc7
Compare
c87de76
to
475f99c
Compare
2981fc7
to
a6a7425
Compare
475f99c
to
51f8210
Compare
a6a7425
to
0eba3d8
Compare
0eba3d8
to
1e952aa
Compare
c03d0b9
to
5c0ea6d
Compare
1e952aa
to
575ef83
Compare
0a97369
to
f2b3a92
Compare
a125796
to
c8fedd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nits, the biggest change is to change package.json to Makefile for Python and create a new one when one does not exist already. In the CLI please do not throw on validation, exit the process with console.error and a error code instead
isTypeScript: generatedFiles.language === Language.TypeScript, | ||
isPython: | ||
generatedFiles.language === Language.PythonSync || | ||
generatedFiles.language === Language.PythonAsync, | ||
isPythonSync: generatedFiles.language === Language.PythonSync, | ||
isPythonAsync: generatedFiles.language === Language.PythonAsync, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be just language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or can't Handlebars handle enums/string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can handle strings, but I think it will be more stable when you for example change the string value in the enum
(it doesn't know enums)
189b7bd
to
2071cf0
Compare
bb72483
to
6cfe58e
Compare
eb869b2
to
004c142
Compare
🚀 Add template init for new SDK
This PR updates the
e2b template init-v2
(ore2b template create
) command to leverage the new E2B Templates SDK, providing a more streamlined and developer-friendly experience for creating sandbox templates.The command will be migrated to just
init
once the Template SDK becomes the default to create new templates.🔧 Key Features
Template Structure
Generated Build Scripts
npm run e2b:build:dev
- Build development templatenpm run e2b:build:prod
- Build production templateTemplate Definition Example