-
Notifications
You must be signed in to change notification settings - Fork 77
Feature/std type #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/std type #747
Conversation
…tationary branch equations; some bits of cleanup
…fer in some cases, and the pipeflow converges faster
…matic with qext and sections
# Conflicts: # src/pandapipes/create.py
# Conflicts: # src/pandapipes/component_models/pipe_component.py # src/pandapipes/component_models/pump_component.py # src/pandapipes/create.py # src/pandapipes/pf/derivative_calculation.py # src/pandapipes/test/api/test_components/test_heat_consumer.py # src/pandapipes/test/api/test_components/test_pipe.py
|
Following our discussion about standard types, I checked the ISOPLUS catalog I think it could be useful to add the following P235GH/PUR/PEHD pipe type. The dimensions can be found in: 2.2 ISOPLUS – Einzelrohr The 2.2.5 Wärmeverlust ISOPLUS – Einzelrohr Diskonti I have just prepared this, and it is available as a CSV for DN 20–100 for the three insulation thicknesses. This would look like: A note regarding the outer diameter: it currently refers to the media pipe only, not including the insulation. Would it be sufficient to use this naming and the CSV directly, or do we need to formally request anything from ISOPLUS first? @SimonRubenDrauz |
|
After a short discussion in today’s weekly meeting, we agreed that referencing ISOPLUS as the source is sufficient. Therefore, the following data can be added. I'm providing this as a comment rather than opening a separate pull request from a fork of your branch, which seems more efficient. So please integrate the new pipe types directly in this pull request. Source (ISOPLUS): Used Chapters: |
No description provided.