Conversation
|
Thanks for your contribution. But could you please change the _version back to it's original? Since with the new release, it will be version 3.0.0. |
Of course! I changed the version back. As a result some of the automatic tests should now fail. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2375 +/- ##
===========================================
- Coverage 76.00% 75.98% -0.03%
===========================================
Files 282 282
Lines 32950 32961 +11
===========================================
Hits 25045 25045
- Misses 7905 7916 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Heiner92, I looked into your commit: The standard assumption of the units is wrong. pp normally calculates in MW, MVar and kA. Can you change the signature to reflect that? |
There was a problem hiding this comment.
power is normally measured in MW, current in kA. Voltage is in p.u. aka arbitrary units, which can be recalculated by multiplying res_bus.vm_pu with bus.vn_kv. So a binary switch which will change between pu and rated_voltage would suffice.
Added more information on hover of results inside plotly graphs.
Note: I had to manually adjust the _version.py of pandapower in order to make the tests work. The reason being that the file-format version is already adjusted and does not match with the package version.
With the next release you would either have to change to a new main version 3.0 or change the logic in convert_format