-
Notifications
You must be signed in to change notification settings - Fork 538
first push of revised harmonic calculation code. #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Docs and Changelog are missing. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2569 +/- ##
===========================================
+ Coverage 74.69% 74.85% +0.16%
===========================================
Files 294 297 +3
Lines 36026 36412 +386
===========================================
+ Hits 26909 27256 +347
- Misses 9117 9156 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File names in python should not use capital letters. This goes for all Test_Case_x.py files. See PEP8
Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed.
|
|
Since I am no expert in harmonics analysis, I can not finish this PR.
Help would be much appreciated! |


PR to include the code already created in #1292
It includes a new method for calculating harmonics.