Skip to content

Conversation

@vogt31337
Copy link
Contributor

PR to include the code already created in #1292

It includes a new method for calculating harmonics.

@vogt31337
Copy link
Contributor Author

Docs and Changelog are missing.

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

❌ Patch coverage is 89.40568% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.85%. Comparing base (6a05449) to head (ce7951d).
⚠️ Report is 65 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/harmonics/harmonic_impedance_creator.py 72.26% 33 Missing ⚠️
pandapower/harmonics/balanced.py 92.63% 7 Missing ⚠️
pandapower/pd2ppc_zero.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2569      +/-   ##
===========================================
+ Coverage    74.69%   74.85%   +0.16%     
===========================================
  Files          294      297       +3     
  Lines        36026    36412     +386     
===========================================
+ Hits         26909    27256     +347     
- Misses        9117     9156      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vogt31337 vogt31337 mentioned this pull request Mar 31, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File names in python should not use capital letters. This goes for all Test_Case_x.py files. See PEP8

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

@vogt31337 vogt31337 marked this pull request as draft October 9, 2025 09:48
@vogt31337 vogt31337 added help wanted! We are looking for contributions from the community to help with this issue enhancement New feature or request labels Oct 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@vogt31337
Copy link
Contributor Author

Since I am no expert in harmonics analysis, I can not finish this PR.
For the following help is needed:

  1. The test results need to be validated.
  2. Documentation needs to be written.
  3. Currently the results are just returned, they should be written into the pandapowerNet.

Help would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted! We are looking for contributions from the community to help with this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants