Cim2pp: test to check dtypes of columns #2638
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et element columns
Contributor
|
@lezneew thanks for the PR, but could you validate against the dtypes from an empty network? Since this is the place we normally have all dtypes defined. |
Contributor
Contributor
|
merge needs to wait for fix in cim2pp |
moved from general import to specific ones.
added a "result" which shows what is the expected result, only if differences are found.
modified description parameter in case of an dtype error, so that it will always stay on top.
# Conflicts: # CHANGELOG.rst # pandapower/test/converter/test_from_cim.py
Contributor
|
maybe moving to pandera validation is the better longterm see #2717, might even make it redundant |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cim2pp converter: added test to check standard dtypes of pandapower net element columns