Jao converter #2755
Open
Jao converter #2755
+2,018
−594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandapower/converter/jao/from_jao.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2755 +/- ##
===========================================
- Coverage 71.62% 71.59% -0.03%
===========================================
Files 351 352 +1
Lines 37174 37797 +623
===========================================
+ Hits 26626 27062 +436
- Misses 10548 10735 +187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KS-HTK
requested changes
Oct 15, 2025
Collaborator
KS-HTK
left a comment
KS-HTK
left a comment
There was a problem hiding this comment.
Have not looked at all of the code as there is a lot to cover here… But some changes are required.
[CHANGED] refactored code
Refactored Code
… utils functions refactored code removed unused function
KS-HTK
requested changes
Nov 6, 2025
pandapower/converter/jao/from_jao.py
Outdated
| ------ | ||
| KeyError | ||
| When primary/secondary voltage columns cannot be located via fuzzy matching. | ||
| """ |
Collaborator
There was a problem hiding this comment.
Why was a Documentation removed without replacement?
Collaborator
There was a problem hiding this comment.
Multiple docstrings were removed. Is there a reason?
pandapower/converter/jao/utils.py
Outdated
| def multi_str_repl(st: str, repl: list[tuple]) -> str: | ||
| for (old, new) in repl: | ||
| st = st.replace(old, new) | ||
| return st No newline at end of file |
|
KS-HTK
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converter now uses fuzzy matching with difflib module to find matching buses instead of using hard coded name corrections as well as table column names if they are inconsistent between files