-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add IsPalindrome snippet with unit test and README entry #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tarun2684
wants to merge
5
commits into
e5LA:main
Choose a base branch
from
tarun2684:feat/is-palindrome
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7665c2f
feat: Implemented a Palindrome check function
tarun2684 6d717ed
fix/update the REASDME.md for Palindrome function
tarun2684 80b22e2
fix/rename test functions to use backticks and natural language descr…
tarun2684 067c55f
Merge branch 'main' into feat/is-palindrome
e5LA 435c72c
Merge branch 'main' into feat/is-palindrome
e5LA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
src/main/kotlin/codecollection/snippets/strings/IsPalindrome.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package codecollection.snippets.strings | ||
|
||
fun isPalindrome(input: String): Boolean { | ||
val filtered = input.filter { it.isLetterOrDigit() }.lowercase() | ||
return filtered == filtered.reversed() | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/test/kotlin/codecollection/snippets/strings/IsPalindromeTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package codecollection.snippets.strings | ||
|
||
import kotlin.test.Test | ||
import kotlin.test.assertFalse | ||
import kotlin.test.assertTrue | ||
|
||
class IsPalindromeTest { | ||
|
||
@Test | ||
fun testPalindromeWithSimpleWord() { | ||
assertTrue(isPalindrome("madam")) | ||
} | ||
|
||
@Test | ||
fun testPalindromeWithPunctuation() { | ||
assertTrue(isPalindrome("A man, a plan, a canal: Panama")) | ||
} | ||
|
||
@Test | ||
fun testNonPalindrome() { | ||
assertFalse(isPalindrome("hello")) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the rest of the codebase, please rename test functions using backticks and natural language descriptions (e.g., fun
recognizes simple word palindrome
()). Here and in functions below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the feedback! 🙌
I’ll update the test function names to use backticks and natural language descriptions as suggested (e.g., fun recognizes simple word palindrome()), to keep it consistent with the rest of the codebase. Appreciate you pointing that out — will make the changes shortly!