fix: Do not override custom SSL context certificate validation settings#650
Open
vustym wants to merge 1 commit intoeBay:masterfrom
Open
fix: Do not override custom SSL context certificate validation settings#650vustym wants to merge 1 commit intoeBay:masterfrom
vustym wants to merge 1 commit intoeBay:masterfrom
Conversation
Do not override certificate verification mode and verification callback if a cusom SSL context is supplied.
vustym
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a custom SSL context is passed, that must be fully configured, as stated in the doc.
Full configuration also includes the certificate verification mode and verification callback.
Current version overrides those, so certificate validation may behave unexpectedly.
The fix is to not set the verification mode and callback if the context is custom.