Skip to content

Remove usage of folly::Expected.#284

Merged
szmyd merged 2 commits intoeBay:masterfrom
szmyd:remove_folly_expected
Nov 15, 2025
Merged

Remove usage of folly::Expected.#284
szmyd merged 2 commits intoeBay:masterfrom
szmyd:remove_folly_expected

Conversation

@szmyd
Copy link
Copy Markdown
Collaborator

@szmyd szmyd commented Nov 14, 2025

No description provided.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.27%. Comparing base (370c772) to head (de6714d).
⚠️ Report is 69 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   64.29%   61.27%   -3.03%     
==========================================
  Files          72       70       -2     
  Lines        4406     4741     +335     
  Branches      555      646      +91     
==========================================
+ Hits         2833     2905      +72     
- Misses       1327     1573     +246     
- Partials      246      263      +17     
Components Coverage Δ
AuthManager 77.77% <ø> (ø)
Cache 37.85% <76.92%> (+7.91%) ⬆️
FDS 74.83% <92.85%> (+3.71%) ⬆️
FileWatcher 58.51% <60.00%> (+2.26%) ⬆️
Flip 65.34% <ø> (ø)
gRPC 76.04% <62.16%> (-1.01%) ⬇️
Logging 15.25% <3.83%> (-14.93%) ⬇️
Metrics 80.57% <ø> (+0.36%) ⬆️
Options 100.00% <ø> (ø)
Setting 57.61% <ø> (+0.82%) ⬆️
StatusObject 73.83% <ø> (ø)
Utility 83.51% <100.00%> (+0.80%) ⬆️
Version 95.83% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@szmyd szmyd requested a review from raakella1 November 14, 2025 20:09
@szmyd szmyd merged commit 3bdb0c5 into eBay:master Nov 15, 2025
4 checks passed
@szmyd szmyd deleted the remove_folly_expected branch November 15, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants