Merged
Conversation
Code Coverage Results
|
psi77
previously approved these changes
Jun 10, 2025
Contributor
psi77
left a comment
psi77
left a comment
There was a problem hiding this comment.
I think if this fixes the bug we should merge it as is and then raise a separate ticket for looking at the button facade and refactoring it into something more appropriate
🚀
blaise17
commented
Jun 10, 2025
| const testBoard = new OBFBoard().deserialize(testBoardJSON); | ||
| boardSet.setBoard('test', testBoard); | ||
|
|
||
| service.retrieve().subscribe({ |
Contributor
Author
There was a problem hiding this comment.
Does this want to fail? or just warn?
Failure means the test can never get cleaned up because we don't then run the delete.
Warning means the test can never end up deleting real data that has a key clash (may be irrelevant due to domain scoping?)
Contributor
Author
I've rasied #234 to address the facade refactor. |
psi77
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ButtonFacade is now no longer a facade...
Other options include: