Closes #1020 - Move Comment field from Comment tab to QSO tab#1033
Open
ea5wa wants to merge 1 commit into
Open
Closes #1020 - Move Comment field from Comment tab to QSO tab#1033ea5wa wants to merge 1 commit into
ea5wa wants to merge 1 commit into
Conversation
Add commentLineEdit and keepCommentCheckBox to MainWindowInputQSO, placed on a full-width row below Name/Power with equal spacing. Remove MainWindowInputComment class entirely and migrate all callers in MainWindow to use QSOTabWidget instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Build and Checked in windows. Working perfectly |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1020
Summary
Commentfield from its own dedicated tab (MainWindowInputComment) into theQSOtab (MainWindowInputQSO), saving users a tab click on every QSOKeepcheckbox at the right end and consistent spacing with the rest of the tabMainWindowInputCommentclass entirely; all callers inMainWindowmigrated toQSOTabWidgetBehaviour preserved
getComment()/setComment()— moved toMainWindowInputQSOKeep this data for next QSOcheckbox —keepCommentCheckBoxadded next to the fieldclear()respects the keep flaggetQSOData()/setQSOData()include the comment fieldbackupCurrentQSO/restoreCurrentQSO) updated accordinglyFiles affected
src/inputwidgets/mainwindowinputqso.h/.cpp— new field, methods, layoutsrc/inputwidgets/mainwindowinputcomment.h/.cpp— deletedsrc/mainwindow.h/.cpp— member removed, all calls migratedsrc/CMakeLists.txt— source removedtests/tst_mainwindow/CMakeLists.txt/tst_mainwindow.cpp— references removedTest plan
🤖 Generated with Claude Code