Add Python reprs (implemented in rust) #1217
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
enhancement ✨
TomNicholas
commented
Sep 10, 2025
icechunk/src/display.rs
Outdated
| @@ -0,0 +1,26 @@ | |||
| pub fn dataclass_repr(class_name: &str, attributes: &[(&str, &str)]) -> String { | |||
There was a problem hiding this comment.
I used a slice here because it seemed to be a simple way to pass an ordered list of str-str pairs. I first tried a HashMap but that doesn't preserve order which led to my reprs looking different every time!
Apparently there is an IndexMap thing that preserves insertion order, which sounds neat, but I didn't use that because it would have added a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #1208, supercedes #1209.
To-do: