External Tests don't run on external PRs #1265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split rust-ci tests: basic tests for external PRs, full tests for trusted PRs - External PRs run unit tests only (--lib) without external service secrets - Internal PRs and labeled external PRs get full integration testing - Added label-based approval: maintainers can add 'test-external-services' label - Added manual dispatch workflow for on-demand external PR testing - Reusable workflow design prevents code duplication - Maintains security while enabling external contributions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Split rust-ci into separate jobs: rust-safe (immediate) + rust-external-services (approval required) - rust-safe: runs unit tests, MinIO/Azurite integration tests, doc tests, examples across all platforms - rust-external-services: requires 'external-services' environment approval for AWS/R2/Tigris tests - External PRs get comprehensive feedback immediately while secrets remain protected - Maintainers can review code changes before approving external service tests - Uses GitHub's built-in deployment protection with audit trail - Optimized external tests to only run AWS/R2/Tigris (excludes redundant MinIO tests) - Maintains backward compatibility with workflow_call for reusability - Removed separate test-external-pr.yaml (functionality now integrated) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…iciency - Merge rust-external-services and rust-cron-integration into single job - For manual approval (PR/push): Run targeted external service tests (AWS, R2, Tigris) - For cron schedule: Run comprehensive integration tests (all ignored tests) - Remove duplicate job infrastructure and unnecessary Docker setup - Maintain same deployment protection for both execution modes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update environment name from external-services to ci-with-secrets - Leverages existing GitHub environment configuration - Maintains deployment protection for external service tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Single rust-external-services job with conditional environment protection: - External PRs: Require manual approval via ci-with-secrets environment - Internal PRs & cron: Run automatically without environment protection - Combines external services and cron integration into unified job - Maintains test separation: safe tests (MinIO/Azurite) vs external services 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Clean up leftover file from shared workflow approach. Using single job with conditional environment protection instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Remove inputs.ref which only applies to reusable workflows. Use standard github.event.pull_request.head.sha || github.sha instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove unused workflow_call section and inputs - Remove 'labeled' trigger that was for abandoned label-based bypass - Keep clean regular workflow without reusable workflow leftovers 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same branch as #1226 but on a branch form within the repo to make sure the tests all run properly