Enable B (flake8-bugbear) ruleset and fix violations#1362
Open
Sherwin-14 wants to merge 3 commits into
Open
Conversation
mfisher87
requested changes
Jun 6, 2026
| ) | ||
|
|
||
| @lru_cache | ||
| @lru_cache # noqa:B019 |
Member
There was a problem hiding this comment.
Maybe we should actually fix this one. Is it important for this function to return a unique httpfilesystem per instance of Store? I'm not sure at the moment. @betolink
Member
There was a problem hiding this comment.
Also, unrelated to this PR, but either the docstring or the return type annotation are wrong. Does this return AbstractFileSystem or HTTPFileSystem (I mean, technically both, but the "correcter" annotation should be the most specific, HTTPFileSystem, right?)
We shouldn't keep type information in the docstrings because it leads to this kind of sync problem. Autodoc will read the types from the function signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed errors and violations as a result of enabling B rulesets. Related to #383.
📚 Documentation preview 📚: https://earthaccess--1362.org.readthedocs.build/en/1362/