Fix setting of component directories when using buildininstalldir#4065
Fix setting of component directories when using buildininstalldir#4065Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Conversation
|
Even with this fix I am still hitting the error: The |
|
That easyconfig didn't work in earlier EB versions did it? easybuild-easyblocks/easybuild/easyblocks/generic/tarball.py Lines 112 to 116 in 27af3bc Then of course the directory won't exist anymore |
|
I've just add the BLAST to the easyconfig, since the version I need was archived last month. So in original (5m old) all works ok. |
|
ModPipe v2.3.1 from this PR could be built with this update to the bundle.py (on develop) now |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3915410384 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 6 out of 8 (total: 2 mins 42 secs) (8 easyconfigs in total) |
|
@boegelbot please test @ jsc-zen3 |
|
Not sure why |
Yeah... copied that from an older PR, see also #4040 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3915631003 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 3 mins 19 secs) (1 easyconfigs in total) |
|
Changes here look sane to me. Cannot test this further at the moment. We should probably think about a well-suited test suite for this EasyBlock to test these PRs with. Probably something for a regression test suite. |
(created using
eb --new-pr)Fixes #4037 see easybuilders/easybuild-easyconfigs#23852 (comment)