Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the default credible interval to 95% across the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR updates the package documentation (vignettes, README, and Rd/roxygen docs) to remove outdated references to a default 89% interval—especially around ROPE—and align narrative examples with the current 95% default.
Changes:
- Updated vignettes/README/Rd docs to remove “default 89% CI/HDI” language and reference 95% where appropriate.
- Refined explanatory text around CI stability/ESS/MCSE in CI/HDI/ETI documentation.
- Reformatted several R functions (rope/ci/equivalence_test/mediation/hdi) for readability without intended behavioral changes.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| vignettes/region_of_practical_equivalence.Rmd | Removes vignette text claiming default 89% HDI for ROPE. |
| vignettes/mediation.Rmd | Updates vignette text to 95% default credible intervals for mediation. |
| vignettes/example2.Rmd | Updates CI text to 95% and reformats chunks/markdown (currently has broken fences). |
| vignettes/credible_interval.Rmd | Expands discussion of 89% vs 95% and adds MCSE/ESS guidance (currently has duplication). |
| vignettes/bayestestR.Rmd | Updates getting-started vignette to reference 95% credible intervals. |
| man/spi.Rd | Minor Rd wording/formatting updates for CI default text. |
| man/sexit.Rd | Minor Rd wording/formatting updates for CI default text. |
| man/rope.Rd | Updates ROPE title/description and default interval wording (needs alignment with implementation). |
| man/mediation.Rd | Updates mediation docs to state 95% default credible intervals. |
| man/hdi.Rd | Updates HDI details text (MCSE/ESS guidance and formatting). |
| man/eti.Rd | Updates ETI details text (MCSE/ESS guidance and formatting). |
| man/equivalence_test.Rd | Updates equivalence test docs to reference 95% interval wording and formatting. |
| man/distribution.Rd | Improves argument descriptions for distribution helpers. |
| man/ci.Rd | Updates examples to include 0.95 in CI vectors. |
| man/bci.Rd | Updates BCa interval docs text (MCSE/ESS guidance and formatting). |
| README.Rmd | Updates README examples and ROPE default interval wording (needs alignment with implementation). |
| R/rope.R | Updates ROPE roxygen text/title and reformats methods (docs currently conflict with default ci_method). |
| R/mediation.R | Updates roxygen wording (89% -> 95%) and reformats functions for readability. |
| R/hdi.R | Updates roxygen text (MCSE/ESS guidance) and reformats several functions. |
| R/equivalence_test.R | Updates roxygen wording (89% -> 95%) and reformats methods for readability. |
| R/ci.R | Updates roxygen examples and reformats several functions for readability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request aims to remove the default 89% CI and standardize on 95%. The changes primarily involve updating documentation and examples to reflect this, along with some code reformatting for style consistency. The changes are generally good and align with the PR's goal. I've identified a few minor issues: two function definitions that are now inconsistent with the project's style guide, and a couple of broken code blocks in a vignette file that will likely prevent it from rendering correctly. Applying the suggested fixes will improve code consistency and resolve the vignette rendering issues.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/bayestestR into final-fix-to-default-95
|
These snapshottssssssss..... @DominiqueMakowski wdyt? |
@etiennebacher is investigating possible related issues here: Not sure what's wrong with snapshot testing |
This comment has been minimized.
This comment has been minimized.
58747f1 to
cdaf277
Compare
| samples is sufficient to estimate the interval at the desired probability | ||
| level with good precision. | ||
| **people started using 95\%**, the arbitrary convention used in the **frequentist** world. | ||
| However, some authors suggested that 95\% might not be the most appropriate for Bayesian posterior distributions [@kruschke2014doing]. |
There was a problem hiding this comment.
Where in the book does Kruschke actually suggest this though? I've searched for all of the cases of 95% and 90% in the 2014/2015 edition and as far as I can find, he doesn't actually suggest using a width other than 95% anywhere. He discusses the stability of the tails in the section on ESS/MSCE (p 184 – 186), but even there he doesn't suggest using a narrower interval at all.
There was a problem hiding this comment.
@DominiqueMakowski do you know? I think you originally wrote that section.
Closes #753