Skip to content

Improve pragma no cover rationale #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krucod3 merged 1 commit into from
Nov 12, 2024
Merged

Improve pragma no cover rationale #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ankaios_sdk/ankaios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ def _read_from_control_interface(self) -> None:
AnkaiosConnectionException: If an error occurs
while reading the fifo.
"""
# The pragma: no cover is used on small checks that are not expected
# to fail. This method is difficult to test and testing each check
# would be redundant.

# pylint: disable=invalid-name
MOST_SIGNIFICANT_BIT_MASK = 0b10000000
try:
Expand Down Expand Up @@ -289,7 +293,6 @@ def _read_from_control_interface(self) -> None:
# Check if we reached the last byte
if next_byte[0] & MOST_SIGNIFICANT_BIT_MASK == 0:
break
# Not worth unit testing
if not varint_buffer: # pragma: no cover
continue
# Decode the varint and receive the proto msg length
Expand Down