Fix agent reconnect does not work #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krucod3
reviewed
Dec 6, 2024
Contributor
krucod3
left a comment
krucod3
left a comment
There was a problem hiding this comment.
Looks good, just had a couple of small findings.
I have not tested it yet, but I'll do so and we can merge after the fixes and the test.
krucod3
reviewed
Dec 6, 2024
Co-authored-by: Kaloyan <[email protected]>
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #39
Solution
When the agent gets disconnected, the sdk enters a routine where it tries to send the
hellomessage over and over. Succeeding in sending it means the agent is back. The agent will receive a number ofhellomessages when starting, but this is ok because the first one will be taken into account (and much needed by the whole interaction) and the rest of them will be ignored, thus the communication can continue.Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.