Connection check fails on insufficient privileges #73
Conversation
GabyUnalaq
left a comment
GabyUnalaq
left a comment
There was a problem hiding this comment.
The changes do not fix the issue.
How I tested
I've run the hello_ankaios example with a changed manifest:
examples/manifest.yaml:
...
controlInterfaceAccess:
allowRules:
- type: StateRule
operation: ReadWrite
filterMask:
- "desiredState.workloads"
- "workloadStates"
...And run it in dev mode: ./run_example.sh hello_ankaios dev
Output before:
Output after
Suggestions
By implementing the suggestion from @krucod3 from the issue description, the second line is deleted, but the first one remains: Error while trying to get the state: Access denied.
Hint: This line comes from the Ankaios.get_state method, and this should be suppressed as well in this case.
|
|
|
There should not be any message regarding the access denied. |
There was a problem hiding this comment.
There are 2 cases for when the check if successful:
- The CompleteState with only the apiVersion is returned, thus the connection is fine.
- The request is blocked due to not enough privileges, thus the connection is fine.
In all other cases (ConnectionClosed or ProtocolException), the connection check fails. Because the flag never gets set to True if the apiVersion is successfully returned, the error line in get state for subsequent requests never get's logged in case of a privilege issue.
Issues: #69
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.