fix: Dependency Clash with annotations-api#16
Merged
wba2hi merged 6 commits intoeclipse-kuksa:mainfrom Feb 20, 2025
Merged
Conversation
Resolves the following warning: Using 'getter for first: E!' is an error. 'getFirst()' member of List is redundant in Kotlin and might be removed soon. Please use 'first()' stdlib extension instead. The snippet itself is not using "getFirst" or "first" but the correctly stated "first()" method. Therefore it seems to be a false positive.
wba2hi
force-pushed
the
annotation-dependency-clash
branch
from
b3794f3 to
ff3d550
Compare
lukasmittag
reviewed
Feb 19, 2025
kuksa-java-sdk/src/main/kotlin/org/eclipse/kuksa/extension/vss/VssNodeCopyExtension.kt
Show resolved
Hide resolved
wba2hi
commented
Feb 20, 2025
vss-core/src/main/kotlin/org/eclipse/kuksa/vsscore/annotation/VssModelGenerator.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the gradle.lockfile it can be seen that both dependencies are available:
org.apache.tomcat:annotations-api is added explicitely, but javax.annotation:annotation-api is a transitive dependency.
Due to this, the org.apache.tomcat:annotations-apo dependency should be safe to remove. Somehow it even wonders me, why this build at all and didn't already throw the exception directly when building the sdk.