Skip to content

Conversation

@Ahmed-Elsaka-JC
Copy link
Contributor

  • set permission for kvs file

Closes #99

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC force-pushed the afe_update_file_permissions branch from e60d583 to 3e2d2e2 Compare September 2, 2025 19:16
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 338f9841-ffca-4d08-9c70-5d689993dd5a
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-4mKwezZI/cRJtzanuKwfvj+C0wuCO5C+fxSvAIZIZG8="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (75 packages loaded, 9 targets configured)

Analyzing: target //:license-check (95 packages loaded, 196 targets configured)

Analyzing: target //:license-check (133 packages loaded, 2392 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2546 targets configured)

Analyzing: target //:license-check (141 packages loaded, 4553 targets configured)

Analyzing: target //:license-check (141 packages loaded, 4553 targets configured)

Analyzing: target //:license-check (141 packages loaded, 4553 targets configured)

DEBUG: Rule 'toolchains_llvm++llvm+llvm_toolchain_llvm' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ = [], _original_name = "llvm_toolchain_llvm"
DEBUG: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /home/runner/.bazel/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
INFO: Analyzed target //:license-check (142 packages loaded, 6488 targets configured).
[6 / 14] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_dash_license_checker+/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
[14 / 14] no actions running
INFO: Elapsed time: 194.669s, Critical Path: 0.32s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 65 items.
[main] INFO Found 34 items.
[main] INFO Querying ClearlyDefined for license data for 31 items.
[main] INFO Found 31 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/test_scenarios_rust/0.2.0
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.
[main] INFO A review is required for crate/cratesio/-/test_scenarios_rust/0.2.0.
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23040 .

- set permission for kvs file

Fixes eclipse-score#99
@Ahmed-Elsaka-JC Ahmed-Elsaka-JC force-pushed the afe_update_file_permissions branch from 3e2d2e2 to b1426c9 Compare September 2, 2025 19:18
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

The created documentation from the pull request is available at: docu-html

@joshualicht
Copy link
Contributor

Looks good.

@vinodreddy-g Will the api change for the builder ("storage_mode" method) be implemented in Rust?

@joshualicht joshualicht self-requested a review September 8, 2025 08:07
@vinodreddy-g
Copy link
Contributor

@joshualicht @Ahmed-Elsaka-JC We can discuss in the coming meeting also . We could have the permissions for KVS , but we should not expose the os abstraction enum to the api level ,Since we might use a different file storage api or may be KVS is not file based for longterm. We could have a KVS enum for it and map it tot os abstraction internally.

@joshualicht
Copy link
Contributor

Okay I put it on the meeting-board👍🏻

@joshualicht joshualicht removed their request for review September 11, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: set storage file permission

3 participants